search

medusajs / medusa

The world's most flexible commerce platform.
https://medusajs.com
MIT License
25.81k stars 2.58k forks source link

promotions in Medusa v2 #8632

Closed Snorlax-Chan closed 2 months ago

Snorlax-Chan commented 2 months ago

Bug report

"I want to report a bug regarding promotions in Medusa v2. In the 'What items will the promotion be applied to?' section, it seems that the logic for 'in' and 'not in' filters is reversed. For example, when I want to apply a discount to a specific product like a T-shirt, I have to select 'not in' + the specified product. Shouldn't it actually be 'in' + the specified product?"

Describe the bug

A clear and concise description of what the bug is.

System information

Medusa version (including plugins): Node.js version: Database: Operating system: Browser (if relevant):

Steps to reproduce the behavior

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

A clear and concise description of what you expected to happen

Screenshots

If applicable, add screenshots to help explain your problem

Code snippets

If applicable, add code samples to help explain your problem

Additional context

Add any other context about the problem here

Snorlax-Chan commented 2 months ago

"Additionally, the promotion does not work even when the product equals the specified product. This bug also affects product categories and product collections."

riqwan commented 2 months ago

Hey @Snorlax-Chan,

Thanks for reporting this! I've opened a PR to address this, should be available to use soon.