search

medyo / Fancybuttons

Icons, Borders, Radius ... for Android buttons
1.77k stars 397 forks source link

Font icons colors are edited programmatically #17

Closed abdelrahman-elkady closed 9 years ago

abdelrahman-elkady commented 9 years ago

Editing font icons color using setTextColor(int color)

medyo commented 9 years ago

Looks cool :+1: , however it'll be more interesting if you could also add a new method to change icon color. In case of someone needs different color than TextColor. Can you handle that ?

abdelrahman-elkady commented 9 years ago

for sure but will need more effort to handle the icons brought from resources (non font icons)

will do it btw even if not fully implemented , can be added on development branch

medyo commented 9 years ago

Just ignore Icons from resources, just focus on Font Icons. the variables to check are mIconResource and mIconPosition

abdelrahman-elkady commented 9 years ago

you mean checking those variables for resource icons ?

Btw positioning will not make problems with icon color for the font icons I think

medyo commented 9 years ago

I mean checking those variables just to know which type is used (from resource or font). Because applying color on a resource icon will not take any effect. You can follow that commit : 11c329030a9fd6bd65b117c348790c2b4524fefd to implement that new method setIconColor()

abdelrahman-elkady commented 9 years ago

@medyo review the changes now

medyo commented 9 years ago

Looks cool :+1: Thanks for your contribution