search

medyo / Fancybuttons

Icons, Borders, Radius ... for Android buttons
1.77k stars 397 forks source link

Fix textsize fonticonsize #36

Closed squeeish closed 9 years ago

squeeish commented 9 years ago

Ref #20: Fixed text size and fonticon size xml attributes. Fonticon preview in IDE also changes according to size set.

medyo commented 9 years ago

Perfect, I'll review it as soon as possible.

Thanks @squeeish

medyo commented 9 years ago

Hi @squeeish, Could you refactor the code, I saw many duplicated lines for the same feature, I'd recommend to create new static functions to convert px values topx and vise versa (something like PxToSP ...) . I think a new Utils class will be better to hold these new functions.

What do you think ?

squeeish commented 9 years ago

Sure, I'll take a look into it. Will take some time though as I'm busy nowadays. Also, I'm kind of a noob :smile:

squeeish commented 9 years ago

@medyo I've made the changes.

squeeish commented 9 years ago

@medyo, done!

medyo commented 9 years ago

Thanks @squeeish for your contribution.

Well done :+1:

medyo commented 9 years ago

@squeeish oops,

Thanks