search

medyo / android-about-page

Create an awesome About Page for your Android App in 2 minutes
2.04k stars 281 forks source link

AndroidX Jetpack migration needed #126

Closed anggrayudi closed 4 years ago

anggrayudi commented 5 years ago

Well, I think we need to publish this library with AndroidX Jetpack ASAP. I checked so many dependencies on my project, and found that 3 of 19 dependencies are still using old Support Library. Android About Page is one of them. I am aware that this lib will cause crash to my app since Support Library has different package name with AndroidX Jetpack. We don't have to wait until stable version 1.0.0 is released by Google. We can do it now. I have tested AndroidX and found no problem with it.

medyo commented 5 years ago

Hi @anggrayudi,

Could you propose a pull request of the migration?

anggrayudi commented 5 years ago

Hi @medyo , I'll try. But I can't do it this week because I am extremely busy now. I'll migrate this library when I am done.

anggrayudi commented 5 years ago

@chiinau already made a pull request #128. So, it is your time @medyo to accept it and push to master branch.

medyo commented 4 years ago

Library upgraded to androidX