search

meeb / django-distill

Minimal configuration static site generator for Django
MIT License
441 stars 35 forks source link

Fix typo #45

Closed truetug closed 3 years ago

truetug commented 3 years ago

In section with dict params reverse calls with args not kwargs, it doesn't work that way

File ".../site-packages/django_distill/renderer.py", line 114, in render
  uri = self.generate_uri(url, view_name, param_set)
File ".../site-packages/django_distill/renderer.py", line 159, in generate_uri
  uri = reverse(view_name_ns, args=param_set)
...  
django.urls.exceptions.NoReverseMatch: Reverse for 'detail' with arguments '('pk', 'slug')' not found. 1 pattern(s) tried: ['blog/(?P<slug>[^/]+)_(?P<pk>[0-9]+)/$']
meeb commented 3 years ago

Good catch! Thanks!

meeb commented 3 years ago

Your PR is in release 2.8.1 just pushed to PyPI.