search

meeb / django-distill

Minimal configuration static site generator for Django
MIT License
441 stars 35 forks source link

Allow specifying endpoint url for S3 #92

Closed parkan closed 4 months ago

parkan commented 4 months ago

Many services aside from AWS (for example Cloudflare R2) provide an S3 compatible interface, however the current implementation of the engine is restricted to Amazon. This simple patch allows for uploading to dozens of other hosts, as well as overriding the endpoint for AWS if necessary for e.g. GDPR compliance reasons.

meeb commented 4 months ago

Thanks! Looks like a useful addition. There's a couple of minor tweaks I'll make (e.g. the default for the parameter is None not '' in boto3) and the documentation needs to be updated but otherwise looks fine. I'll merge it into the next release.

parkan commented 4 months ago

thank you for the quick merge :pray:

meeb commented 2 months ago

Sorry for taking a while, your PR is in the latest 3.2.5 release available now.