Open SSS-Says-Snek opened 2 months ago
Same here. Thumbnail doesn't get embedded in the audio files..
Thanks for the issue. There are occasions where a relatively esoteric combination of yt-dlp and ffmpeg flags are required to get some metadata features to work. tubesync does set the same keys as you:
https://github.com/meeb/tubesync/blob/main/tubesync/sync/youtube.py#L164
The only difference is tubesync doesn't set 'writethumbnail': True
for yt-dlp because thumbnails are downloaded separately and enabling this would download two copies of thumbnails with different file names.
I'll poke into it but it would seem that this particular container / encoding pair might require 'writethumbnail': True
to work if your test is correct.
I'm using tubesync to download audio files from my playlist and play them on my phone (with the Musicolet app). I turned on both "Embed thumbnail" and "Embed metadata", and while metadata seems to be working fine, the thumbnails are not appearing in the previews.
What I tried
I tried many different combinations of embedding thumbnail, embedding metadata, writing NFO, and changing the audio codec. None of them had any embedded thumbnails.
I also wrote a test script to see if anything was wrong with yt-dlp. However, I saw that this actually did embed the thumbnail into the file:
with the output
I skimmed tubesync's codebase, and I think that my test script's
writethumbnail
option may have something to do with it? I'm not sure though, since I can't test it because manually running tubesync without a container doesn't seem to be working for me (#534)I also might be entirely getting the wrong idea of what embedding thumbnails is supposed to do 😅 Regardless, loving tubesync rn! Keep up the good work!