search

meeb / whoisit

A Python library to RDAP WHOIS-like services for internet resources such as ASNs, IPs, CIDRs and domains
BSD 3-Clause "New" or "Revised" License
78 stars 20 forks source link

Extended vCardArray parser #18

Closed namper closed 1 year ago

namper commented 1 year ago

Added telephone parsing and removed parser coupling with vCardArray data

meeb commented 1 year ago

Thanks for the PR. Looks good, the only issue I can see is that using TypedDict and the typing will mandate at least Py3.8. This is probably fine, but worth mentioning.

namper commented 1 year ago

We can require typing_extension for 3.6-3.7

meeb commented 1 year ago

That would be an acceptable option. Do you want to add a patch to include typing_extension? If not I can add it before the next release.

meeb commented 1 year ago

Excellent, thanks! I'll bundle this into the next release in a day or two.