search

meeb / whoisit

A Python library to RDAP WHOIS-like services for internet resources such as ASNs, IPs, CIDRs and domains
BSD 3-Clause "New" or "Revised" License
78 stars 20 forks source link

Are there any plans for type annotations? #41

Open sanjacob opened 2 weeks ago

sanjacob commented 2 weeks ago

I am willing to help out if necessary, to add type annotations to the whole library. This would really benefit users who use type checkers in their CI pipelines.

Let me know what you think

meeb commented 2 weeks ago

Sure I'm not opposed to the idea. Do people really type check third party libraries during CI builds? For Python especially that would seem like a nightmare.

sanjacob commented 2 weeks ago

@meeb mypy benefits from having type annotations for third party libraries, e.g. if I call whoisit.ip(...) inside my own class then mypy will know if whatever I do with the result is valid.

meeb commented 2 weeks ago

Fair enough that sounds sane.