search

meebey / SmartIrc4net

IRC C# Library
http://www.meebey.net/projects/smartirc4net/
Other
126 stars 52 forks source link

fix: Listen() deadlock #20

Closed lformella closed 9 years ago

lformella commented 10 years ago

fix: Listen() should return when calling Disconnect() instead of being b.locked with ReadLine() waiting for WaitOne()

meebey commented 9 years ago

Thank you for your contribution!

djkaty commented 9 years ago

This has created a merge conflict in the new transport code and I'll revert it in the next commit to that branch. However, the bug fix is semantically correct so I'll re-write it. This will however change the nature of Listen() such that it returns on a disconnect. As a consequence, Reconnect() will no longer work as expected, for example in test.cs, the application will exit before Reconnect() in ReadCommands() has a chance to complete.

djkaty commented 9 years ago

Disregard. I have fixed both issues in the next commit on transport.