search

meebey / SmartIrc4net

IRC C# Library
http://www.meebey.net/projects/smartirc4net/
Other
127 stars 52 forks source link

.NET 4.0 obsolescence compliance, thread-safe issues, remove redundant code #38

Closed djkaty closed 8 years ago

djkaty commented 9 years ago

The commit does exactly what it says on the tin - gets rid of all the compiler warnings and moves the code forward to use .NET 4.0's type-safe and thread-safe Hashtable replacement containers and also makes a couple of small optimizations.

See: https://msdn.microsoft.com/en-us/library/dd287191(v=vs.110).aspx

I'm being quite anal about the code because I intend to use this library to process thousands of reads and writes per second on an auto-scale Azure cloud eventually, so it needs to work fast and safe :)

Maybe consider making an unstable branch rolling up this and the transport changes? And/or a .NET 4+ branch? Using async/await and TPL could become an option then in the future.

meebey commented 9 years ago

Finished the review. PR is ok besides the said issues and it needs a rebase to get rid of the unneeded commit (4f86e2cc283f39fd585bc908b1780c45b15b4532) because it seems your master has a commit that was already in the official master but you cherry-pick it I think. That is easy to solve though

djkaty commented 9 years ago

Please tell me how to fix the extraneous commit, that was a result of me trying to learn to use rebase yesterday to get rid of the ROOMSTATE/USERSTATE commit+revert commit....

As to the rest, agree on all.

djkaty commented 9 years ago

New diff for you to look at + my responses above. I don't know why Travis CI has suddenly decided not to find log4net anymore :(