[Engine-Twitter] Launch "On Connect Commands" the last thing - Githubissues

meebey / smuxi

Smuxi is an user-friendly and free IRC client for Linux, Windows and Mac OS X based on GNOME / GTK+

https://smuxi.im/

GNU General Public License v2.0

174 stars 46 forks source link

[Engine-Twitter] Launch "On Connect Commands" the last thing #138

Closed knocte closed 10 years ago

knocte commented 10 years ago

This avoids these commands to load before the main/default Twitter-backend chatviews open.

knocte commented 10 years ago

I've updated the PR to remove the move of the Update() methods but still delay some things a bit more.

knocte commented 10 years ago

ping? :)

meebey commented 10 years ago

I couldn't decide yet if backgrounding the commands is good or bad...

knocte commented 10 years ago

I think it's not bad in any case.

In case Server.Connect() was putting the connection worker as a background anyway, backgrounding the commands only makes the threadpool spawn a new thread and the previous one days. -> Neither bad nor good.
In case Server.Connect() was synchronous, backgrounding the commands would make the "OnConnect" commands not block things. -> Good.

knocte commented 10 years ago

So it depends on the protocol implementation, but none of the possibilities is bad IMO.

meebey commented 10 years ago

Methods are usually by design synchronous, so the code afterwards can continue on a known state. In this case I think it should not do harm, as the contract would be between user supplied commands AND the protocol manager's connect implementation. And in this case there should be no relation in either way.

knocte commented 10 years ago

Ammended PR to account for concerns raised.