search

meebey / smuxi

Smuxi is an user-friendly and free IRC client for Linux, Windows and Mac OS X based on GNOME / GTK+
https://smuxi.im/
GNU General Public License v2.0
172 stars 46 forks source link

Moved input box to be only below chat window/user list #211

Closed eukreign closed 9 years ago

eukreign commented 9 years ago

It's really awkward to have the input box extend all the way to the left below the room/chat tabs. It's more intuitive to have the input right below where your text will display in the chatroom.

This pull request causes the input box to line up with the chat window.

eukreign commented 9 years ago

screenshot from 2015-02-04 19 28 50

meebey commented 9 years ago

@me4oslav can I have your blessings on this UI change? See the moved entry from bottom to next to the chat list.

me4oslav commented 9 years ago

@eukreign @meebey If we're gong what that "input box belongs to the chat pane", than why does it extend below the users sidebar too? I think it should extend to the chat pane and that's all.

meebey commented 9 years ago

That is because the user list belongs to the notebook not window.. Changing that will require a big code refactor.

meebey commented 9 years ago

The entry always was a single entry (not per chat)

eukreign commented 9 years ago

Just to clarify the main impetus for this change is to line up where the conversation is happening along with where the input happens. As I'm typing a new message I would like to see the ongoing conversation directly above.

It's not so much about what belongs to what. But... this change is definitely only for Left-to-Right languages. For a Right-to-Left language you'd probably have to get the input box to not go past the user list as @me4oslav suggests.

Does smuxi currently even support RTL languages or are there plans to? If not, then I think having the input box go past the user list (as it is in this pull request) is actually nicer because then there is more room for input (a more common use case is entering text as opposed to viewing/scrolling through user list).

meebey commented 9 years ago

Since this is progress towards the better/right thing, I am merging this. I have no idea how to allow alignment of the TreeView since it is inside a Notebook. Using a single TreeView instnace across different chats will lead to issues with different protocols (since they extend the TreeView functionality).