search

meebey / smuxi

Smuxi is an user-friendly and free IRC client for Linux, Windows and Mac OS X based on GNOME / GTK+
https://smuxi.im/
GNU General Public License v2.0
171 stars 46 forks source link

Engine: ID in MessageDTO, for SQLite (de)serialization #254

Closed knocte closed 7 years ago

knocte commented 7 years ago

Ability for messages to hold an ID started with a Twitter feature in [0]. But it was missing serialization, which was added in [1].

However, SQLiteMessageBuffer serialization was also missing, something which is fixed in this commit

The consequence of this new property not being present in MessageBuffer serialization was that the new timeline links implemented in [0] were only visible in the friends timeline but not in new timelines spawned by the /timeline command.

[0] https://github.com/meebey/smuxi/commit/e2b6670c7d7e5580aa872944a838e92090f564a5 [1] https://github.com/meebey/smuxi/commit/b19662693f28a14a9f9bc7a74f6d288906eb005a

knocte commented 7 years ago

Improved commit message and coding style.