meebey / smuxi

Smuxi is an user-friendly and free IRC client for Linux, Windows and Mac OS X based on GNOME / GTK+
https://smuxi.im/
GNU General Public License v2.0
171 stars 46 forks source link

Frontend-GNOME: remove --debug flag from launcher script #300

Closed knocte closed 4 months ago

knocte commented 4 months ago

This would be making Smuxi much slower than it needs to; since many optimizations may not be enabled when running in debug mode.

If a developer wants to still run in debug mode after this, she still has two options:

a) Use make run which still launches smuxi with the --debug flag.

b) Export env var MONO_OPTIONS=--debug before launching smuxi.

knocte commented 4 months ago

@meebey thanks for merging so quickly, btw did you notice the red CI lanes? the Debian unstable one I'm aware of, but see the nix one? how could we fix that for newer PRs, restricting to github.ref values of 'master' and 'stable' for example?

meebey commented 4 months ago

@knocte thanks for raising. the unstable build failure is known because of Debian's GTK#2 removal. The nix build failure seems to have something to do that pulling this PR isn't working. Not sure why though, PR should be a regular branch that you can check out.

meebey commented 4 months ago

The GitHub action invokes: pkgs.callPackage ./nix/default.nix { gitBranch = "${{ github.ref_name }}"; }'

github.ref_name is set by GitHub and is "300/merge" according to the build output.

Nix then attempts to fetch that branch via:

  src = fetchGit {
    url = "https://github.com/meebey/smuxi.git";
    ref = gitBranch;
    submodules = true;
  };

That call fails with: fatal: couldn't find remote ref refs/heads/300/merge

Either 300/merge is not a valid branch ref of the github.com/meebey/smuxi git repo, or it doesn't like/cope with the "/" in the branch name.

knocte commented 4 months ago

Either 300/merge is not a valid branch ref of the github.com/meebey/smuxi git repo, or it doesn't like/cope with the "/" in the branch name.

In order to test your hypothesis above, I have pushed the same commit of this PR but to a new branch in my fork called "noDebug" (instead of "wip/noDebug", like I originally did; or if you look at it from the PR-CI point of view, "300/merge"), but CI is still broken, this time with this error: https://github.com/knocte/smuxi/actions/runs/8781811127/job/24094593528

Which I paste here:

Run nix-build --expr 'let pkgs = import <nixpkgs> { }; in pkgs.callPackage ./nix/default.nix { gitBranch = "noDebug"; }'
  nix-build --expr 'let pkgs = import <nixpkgs> { }; in pkgs.callPackage ./nix/default.nix { gitBranch = "noDebug"; }'
  shell: sh -e {0}
warning: $HOME ('/github/home') is not owned by you, falling back to the one defined in the 'passwd' file ('/root')
fatal: couldn't find remote ref refs/heads/noDebug
warning: could not update mtime for file '/root/.cache/nix/gitv3/0dlgrxhb3sw67bjmryck4mpsz6y189idaxg7vrcm45p[2](https://github.com/knocte/smuxi/actions/runs/8781811127/job/24094593528#step:4:2)vw1m665g/refs/heads/noDebug': No such file or directory
error:
       … while calling the 'derivationStrict' builtin
         at <nix/derivation-internal.nix>:9:12:
            8|
            9|   strict = derivationStrict drvAttrs;
             |            ^
           10|

       … while evaluating derivation 'smuxi-1.2.1'
         whose name attribute is located at /nix/store/wj8[3](https://github.com/knocte/smuxi/actions/runs/8781811127/job/24094593528#step:4:3)y3qvj8v29d5zz0fih03682jf6qr1-b9zng82injl[4](https://github.com/knocte/smuxi/actions/runs/8781811127/job/24094593528#step:4:5)hg2cywz0ql8s9jiylnw0-source/pkgs/stdenv/generic/make-derivation.nix:348:7

       … while evaluating attribute 'src' of derivation 'smuxi-1.2.1'
         at /__w/smuxi/smuxi/nix/default.nix:24:3:
           23|
           24|   src = fetchGit {
             |   ^
           2[5](https://github.com/knocte/smuxi/actions/runs/8781811127/job/24094593528#step:4:6)|     url = "https://github.com/meebey/smuxi.git";

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: opening file '/root/.cache/nix/gitv3/0dlgrxhb3sw[6](https://github.com/knocte/smuxi/actions/runs/8781811127/job/24094593528#step:4:7)7bjmryck4mpsz6y189idaxg7vrcm45p2vw1m665g/refs/heads/noDebug': No such file or directory
Error: Process completed with exit code 1.

Is the real issue more clear now?