search

meedan / check

Development environment for Meedan Check, a collaborative media annotation platform
https://meedan.com/check
MIT License
125 stars 53 forks source link

Remove inline styling in favor of material-ui makeStyles #17

Closed amoedoamorim closed 3 years ago

amoedoamorim commented 3 years ago

Tell us about your request Remove inline styling in favor of material-ui makeStyles

Which service(s) is this request for?

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard? In order to achieve a better code organization, we're shifting away from inline styling. Also, by using material-ui's css-in-js solution we benefit from the rtl layout handling. When we need to apply custom styles to material-ui components it makes sense to use makeStyles to do so.

Sample code locations (not limited to):

https://github.com/meedan/check-web/blob/develop/src/app/components/FlashMessage.js#L65 https://github.com/meedan/check-web/blob/develop/src/app/components/layout/ColorPicker.js#L28 https://github.com/meedan/check-web/blob/develop/src/app/components/source/UserPrivacy.js

deepakchethan commented 3 years ago

Hello @amoedoamorim, I can take this up if it's up for grabs

ghost commented 3 years ago

M here also

amoedoamorim commented 3 years ago

@deepakchethan I have assigned it to you! Thanks for your interest. Please go ahead and let us know if you have any trouble.

abhisheknaiidu commented 3 years ago

@amoedoamorim If it's not being worked on, I want to work on this. Thanks

aryangulati commented 3 years ago

Yeah me too if it not resolved yet