search

meedan / check

Development environment for Meedan Check, a collaborative media annotation platform
https://meedan.com/check
MIT License
125 stars 53 forks source link

Replace `prop.intl.formatMessage` with `<FormattedMessage />` #20

Closed amoedoamorim closed 3 years ago

amoedoamorim commented 3 years ago

Tell us about your request Replace prop.intl.formatMessage with <FormattedMessage />

Which service(s) is this request for? Let us know which services(s) you want this for?

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard? As per our recent coding practices we are now favoring the usage of react-intl instead of prop.intl.formatMessage. <FormattedMessage /> can receive a function as a child to which will be passed the translated string. It is useful when it's required to pass a string rather than a element.

Sample code locations (not limited to): https://github.com/meedan/check-web/blob/develop/src/app/components/media/CreateRelatedMediaDialog.js#L100 https://github.com/meedan/check-web/blob/develop/src/app/components/task/EditTaskDialog.js#L241 https://github.com/meedan/check-web/blob/develop/src/app/components/task/EditTaskDialog.js#L247

sparkingdark commented 3 years ago

Assign it to me i want to work @amoedoamorim .

amoedoamorim commented 3 years ago

Awesome @sparkingdark ! Thank you for your interest! I have assigned the issue to you, please go ahead!

sparkingdark commented 3 years ago

Thanks Am i need to recode it to the given instruction?

sparkingdark commented 3 years ago

Hey @amoedoamorim can you tell me how to build it and run in my local computer I got error while i run 

docker-compose exec web npm run test:unit
ERROR: 
        Can't find a suitable configuration file in this directory or any
        parent. Are you in the right directory?

        Supported filenames: docker-compose.yml, docker-compose.yaml

Am i need to create a file or need to clone all the repo recursively?

sparkingdark commented 3 years ago

@amoedoamorim can you check my pull request in check-web ? https://github.com/meedan/check-web/pull/716

ShyamPraveenSingh commented 3 years ago

Hi @amoedoamorim I would like to work on it. Please assign it to me.

amoedoamorim commented 3 years ago

Am i need to create a file or need to clone all the repo recursively?

Yes, to run Check locally you need to clone the whole check repo recursively. Please follow the steps at https://github.com/meedan/check#quick-start and let us know if you have any difficulty.

sparkingdark commented 3 years ago

Okay

gabrielrab commented 3 years ago

Hi! Could you assign me this problem, I sent my PR with resolution of that issue.

swapniljha001 commented 3 years ago

Is this issue still open?

sneha-mehta commented 3 years ago

Is it still open?? Can I make a contribution too?

NilmaPeiris commented 3 years ago

hey I sent my PR with resolution of that issue.

aeyshubh commented 3 years ago

hi @sparkingdark ,i want to work on it can you just give me a brief and in which document i have to do the replace work ? Regards, Shubham patel