search

meedan / check

Development environment for Meedan Check, a collaborative media annotation platform
https://meedan.com/check
MIT License
125 stars 53 forks source link

Cleaned up bash scripts according to shellcheck errors #32

Closed sdushantha closed 3 years ago

sdushantha commented 3 years ago

Hey!

I went ahead and ran shellcheck on the bash scripts located in the "bin" directory and made some corrections according to the errors given by shellcheck.

Majority of the changes that were made were basic things such as adding double quouts around variables, using $() instead of the legacy backticks.

danielafeitosa commented 3 years ago

Thank you, @sdushantha!

Was this an automatic fix? Could you run these scripts and paste the output here just to make sure everything is ok, please?

sdushantha commented 3 years ago

@danielafeitosa

Was this an automatic fix?

This was a manual fix. shellcheck only shows errors, but I have to manually go into the script and make the changes myself.

Could you run these scripts and paste the output here just to make sure everything is ok, please?

I unfortunately cannot do that because I don't have the needed programs installed, such as docker. I also don't have certain files which these scripts are looking for because they are not to be found in this repo.

I ran all the scripts with bash -n which does not exactly run the script, but check for syntax errors, and no errors were found. So I can assure that these scripts should be working just as they used to in the past :)

sdushantha commented 3 years ago

@danielafeitosa Just a friendly reminder about this PR. Hacktoberfest is ending soon and I would like this PR to be included in my Hacktoberfest progress :)