meedan / check

Development environment for Meedan Check, a collaborative media annotation platform
https://meedan.com/check
MIT License
127 stars 53 forks source link

Redis HealthCheck - "FIXME" #44

Open Better-Boy opened 4 years ago

Better-Boy commented 4 years ago

Which service(s) is this report about? Let us know which services(s) this report is about:

Description: # FIXME Redis database is not being tested by info() - https://github.com/meedan/alegre/blob/develop/app/main/controller/healthcheck_controller.py#L44

Currently, in health check in redis, more than needed information is fetched from the redis using r.info() which is not used anywhere in the healthcheck code.

Better-Boy commented 4 years ago

I have fixed this with explanation in the PR https://github.com/meedan/alegre/pull/36

Better-Boy commented 4 years ago

@computermacgyver This issue is fixed with the PR merged yesterday in the alegre repository. Can this issue be closed with the tags hacktoberfest and the component as alegre?