Closed hartsick closed 2 years ago
I think this is failing because the submodules need to be bumped once the dependent branches are merged into their respective develop
branches. Seems like it errored out on pinging the alegre service on the 3100 port
Can we remove all of those lines?
On Mon, Jul 25, 2022 at 12:39 PM Christa Hartsock @.***> wrote:
@.**** commented on this pull request.
In docker-compose.yml https://github.com/meedan/check/pull/69#discussion_r929087555:
@@ -12,6 +12,7 @@ networks: services: elasticsearch: build: alegre/elasticsearch
- platform: linux/x86_64
I just built locally without (docker-compose build elasticsearch), so I think so! will remove.
— Reply to this email directly, view it on GitHub https://github.com/meedan/check/pull/69#discussion_r929087555, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADFBK3KEGD7H2TEYQ5OD6DVV27KJANCNFSM54MJ2GYA . You are receiving this because your review was requested.Message ID: @.***>
Changes needed to get development environment running on M1 macs - will open other PRs on branches in other relevant repositories.
I marked this PR as draft so that it doesn't get accidentally merged before Aaron's review and the submodule bumps once the dependent PRs are merged. But I don't intend on making any changes other than that unless they're needed.