search

meedan / montage-components

Monorepo of components for Montage
https://montage.meedan.com
0 stars 0 forks source link

Video aspect ratio is incorrect #54

Open maboa opened 5 years ago

maboa commented 5 years ago

For example this video https://www.youtube.com/watch?v=5NQjJ7vRRzw is clipped ~horizontally~ vertically in the current version.

piotrfonte commented 5 years ago

That’s how it is in the Angular version. Closing for now. Feel free to reopen if I got it wrong.

maboa commented 5 years ago

I'm reopening but deprioritising as I think its something we should consider improving at some point.

Laurian commented 5 years ago

What is the correct aspect ratio? each video can be different, and especially in this context we will even have vertical video… (but we can know the video w/h from YT data and show a player that fits, the issue is how the rest in the page fits?)