meeech / shopify.tmbundle

A bundle for interacting with Shopify Theme Assets.
http://meeech.github.com/shopify.tmbundle/
136 stars 31 forks source link

customers/.. template don't get uploaded #31

Closed thob closed 13 years ago

thob commented 13 years ago

Hi,

I'm having issues with the new customer account templates. They are nested in templates like customers/login etc. none of the 2 upload commands works atm. Thomas

meeech commented 13 years ago

Hey Thob, this is something I will have to look into. Right now, there's no support for the customer stuff (I didn't even know they have sep. templates :) haven't even had a chance to try it yet). I'll update this once I have a chance to examine the customer stuff.

thob commented 13 years ago

I think Customer Accounts are still in beta though the docu is there already http://wiki.shopify.com/Customer_Accounts

carolineschnapp commented 13 years ago

The Textmate bundle is able to get an entire theme that already contains customer templates.

It's not able to update any of those customers templates, though.

The error is:

 Could not upload customers/login.liquid to default.

'default' is the name of the shop config in .shopify-tmbundle.

Paul Pritchard from ACME Creative reported the problem to me, and I was able to reproduce it with an up-to-date Shopify Textmate bundle.

The customers templates reside in a sub-folder. Could that be the problem?

They have been created — in my tests — on the Template Editor page online, not in Textmate.

I am able to get them, but unable to update them, in Textmate.

Thanks for looking into this, Meeech.

carolineschnapp commented 13 years ago

Designers already published in the theme store have gotten the word to add customer accounts support in their themes. Our official themes have been updated, and new themes need to support the feature to be published in the theme store.

edward commented 13 years ago

Yep.

When creating these new customer-related templates, you want to use key: templates/customers/login.liquid for example.

meeech commented 13 years ago

Cool. Thanks for the details - this will help. Its def the nested folder thing - I basically dont account for nested folder, so will look to add this.

meeech commented 13 years ago

Hey Caro, edward - I applied a few of the official themes, and see no customer templates in the theme editor. Can you point me to a theme that has customer templates for sure? Is there something else I am missing?

carolineschnapp commented 13 years ago

The themes include JavaScript and CSS for the customer account pages - and they include customer login / logout / account links - but may not have custom templates (HTML/Liquid). But you can add those templates in the Templates section on the Template Editor page:

meeech commented 13 years ago

thanks caroline. issue is now resolved

thob commented 13 years ago

Thanx!

meeech commented 13 years ago

np. let me know if you see any problems. :D thanks for letting me know about it in the first place. it should support any other subdirectories they eventually support in the future.

danielvonmitschke commented 11 years ago

I know this issue has been closed, but still have to ask: Is it possible to use TextMate to upload the customer templates or has this to be done in the Shopify template editor? Because it's not working for me. The customer files are even ignored when downloading the full theme via Textmate.

meeech commented 11 years ago

might be possible eventually when i find some time to work on the bundle

danielvonmitschke commented 11 years ago

thanks a lot for this information. fortunately it's not that bad to work in the online template editor.