meeech / shopify.tmbundle

A bundle for interacting with Shopify Theme Assets.
http://meeech.github.com/shopify.tmbundle/
136 stars 31 forks source link

Added support for Notification Center in OS X Mavericks. #76

Open cordevx2 opened 10 years ago

cordevx2 commented 10 years ago

Added a Notifcation Center alert when uploading individual or multiple assets to Shopify. Users must install the gem 'terminal-notifier'.

Also, this change requires TextMate 2 preview in order for the icon to show up correctly in Notification Center.

meeech commented 10 years ago

Hey Dale, thanks. thats great, but i'm unlikely to merge this in as it now stands. It would need to check if gem is installed and so forth. Anyone without this gem, would just get errors. Not clear from gem what its behaviour would be in pre-10.8 circumstance. Personally, i'd suggest it being a config option you could enable (not something i have time to do).

In anycase, its good you've put this out there - anyone searching for that functionality will now find this fork as well, so thats good.

cordevx2 commented 10 years ago

Great, thanks for the feedback. Much appreciated.

Dale