search

meeg-ml-benchmarks / brain-age-benchmark-paper

M/EEG brain age benchmark paper
https://meeg-ml-benchmarks.github.io/brain-age-benchmark-paper/
BSD 3-Clause "New" or "Revised" License
24 stars 10 forks source link

[don't merge] FIX: reading the actual age for LEMON dataset instead of the guessed age #39

Closed apmellot closed 2 years ago

apmellot commented 2 years ago

@dengemann I am not sure if we should keep the age update line 53.

agramfort commented 2 years ago

I let @dengemann review and merge.

dengemann commented 2 years ago

@apmellot have you tried if it works? Do the results for Lemon change a lot?

apmellot commented 2 years ago

I cannot try if the convertion works because I don't have access to the dataset directory. But I tried to run the riemann and source benchmark with the age in the participants.tsv and I get exactly the same results as before, maybe you did the computation with it already.

dengemann commented 2 years ago

What do you mean you don't have access? Who is the owner of that directory?

apmellot commented 2 years ago

When I run the script I get : PermissionError: [Errno 13] Permission non accordée: '/storage/store3/data/LEMON_EEG_BIDS/bids_conv_erros.csv'

dengemann commented 2 years ago

What script is that anyways? Sounds like @hubertjb may have been active here when fixing the deep learning benchmarks? Can you see who owns that directory by doing an ls -lh? (and Hubert in case it's you please set open permissions).

dengemann commented 2 years ago

I think we should keep things as is, the code as it was may be the right one for external users who don't have the true ages. What happened is that: