search

meeg-ml-benchmarks / brain-age-benchmark-paper

M/EEG brain age benchmark paper
https://meeg-ml-benchmarks.github.io/brain-age-benchmark-paper/
BSD 3-Clause "New" or "Revised" License
24 stars 10 forks source link

`mne.utils._fetch_file` does not exist in mne 0.24.dev #9

Closed gemeinl closed 3 years ago

gemeinl commented 3 years ago

Conversion to bids format will fail with mne 0.24.dev since mne.utils._fetch_file was removed.

agramfort commented 3 years ago

what script does use this? we should not use any private function here

gemeinl commented 3 years ago

It happens in convert_tuh_to_bids.py and is an import in moabb. Here is the traceback

Traceback (most recent call last):
  File "/home/lukas/Code/meeg-brain-age-benchmark-paper/convert_tuh_to_bids.py", line 21, in <module>
    from braindecode.datasets import TUHAbnormal
  File "/home/lukas/Code/braindecode/braindecode/datasets/__init__.py", line 5, in <module>
    from .moabb import MOABBDataset, HGD, BNCI2014001
  File "/home/lukas/Code/braindecode/braindecode/datasets/moabb.py", line 14, in <module>
    from moabb.datasets import Schirrmeister2017, BNCI2014001
  File "/home/lukas/miniconda3/envs/benchmark/lib/python3.9/site-packages/moabb/datasets/__init__.py", line 8, in <module>
    from .alex_mi import AlexMI
  File "/home/lukas/miniconda3/envs/benchmark/lib/python3.9/site-packages/moabb/datasets/alex_mi.py", line 7, in <module>
    from . import download as dl
  File "/home/lukas/miniconda3/envs/benchmark/lib/python3.9/site-packages/moabb/datasets/download.py", line 12, in <module>
    from mne.utils import _fetch_file, _url_to_local_path, verbose
ImportError: cannot import name '_fetch_file' from 'mne.utils' (/home/lukas/Code/mne-python/mne/utils/__init__.py)
agramfort commented 3 years ago

arff it's because moabb was using an mne private function :(

I guess moabb need to be adjusted now...

agramfort commented 3 years ago

using moabb master branch should fix your pb https://github.com/NeuroTechX/moabb/pull/235