search

meejah / txtorcon

Twisted-based asynchronous Tor control protocol implementation. Includes unit-tests, examples, state-tracking code and configuration abstraction.
http://fjblvrw2jrxnhtg67qpbzi45r7ofojaoo3orzykesly2j3c2m3htapid.onion/
MIT License
250 stars 72 forks source link

Support use of stem.version.Version #109

Closed sambuddhabasu closed 9 years ago

sambuddhabasu commented 9 years ago

This fixes #108

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.04%) to 99.87% when pulling 083e0152e5e7701d741965ab6772181eb3cce2ab on sammyshj:usestemversion into a6efb2de1d876bed0c5f408ae9cf99e325b47513 on meejah:master.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.04%) to 99.87% when pulling 083e0152e5e7701d741965ab6772181eb3cce2ab on sammyshj:usestemversion into a6efb2de1d876bed0c5f408ae9cf99e325b47513 on meejah:master.

sambuddhabasu commented 9 years ago

@meejah Please have a look at this PR. If the code looks good, I will go ahead and add tests for this

sambuddhabasu commented 9 years ago

I have added tests for the support of stem.version.Version too

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.08%) to 99.83% when pulling 0153e18a640045499d8226b46cdd3a44efce66b1 on sammyshj:usestemversion into a6efb2de1d876bed0c5f408ae9cf99e325b47513 on meejah:master.

meejah commented 9 years ago

This all looks pretty great, thanks!

I think what I'm going to do is merge all "stem stuff" into the (now horrificially outdated) "stem-integration" branch so we can play with possibly-disruptive changes to see how they feel.

So, I'll rebase stem-integration and merge this into it....

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.0%) to 99.92% when pulling 103444f7861fac3b96b0957e17d54041123c4b9f on sammyshj:usestemversion into a6efb2de1d876bed0c5f408ae9cf99e325b47513 on meejah:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.0%) to 99.92% when pulling 888d53a2e7f13c8fa67d13730e58d9e7a511cdae on sammyshj:usestemversion into a6efb2de1d876bed0c5f408ae9cf99e325b47513 on meejah:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.0%) to 99.92% when pulling 7bb0d83baa473631e4cd37aec0a85d65f36a5fb9 on sammyshj:usestemversion into a6efb2de1d876bed0c5f408ae9cf99e325b47513 on meejah:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.0%) to 99.92% when pulling 9c604f3e953b948f87ee55f8d799d4051b21e40e on sammyshj:usestemversion into a6efb2de1d876bed0c5f408ae9cf99e325b47513 on meejah:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.0%) to 99.92% when pulling 922c9a148ccb5682a2de4b10fa5fbbdc018ef0f1 on sammyshj:usestemversion into a6efb2de1d876bed0c5f408ae9cf99e325b47513 on meejah:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.0%) to 99.92% when pulling 922c9a148ccb5682a2de4b10fa5fbbdc018ef0f1 on sammyshj:usestemversion into a6efb2de1d876bed0c5f408ae9cf99e325b47513 on meejah:master.

sambuddhabasu commented 9 years ago

The required changes that were pointed out by @meejah were made. Now, the stem.version is tried to be imported only when use_stem is True. Also, the related tests have been added and all the tests pass successfully. If everything seems good, I will squash the commits into a single commit

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.0%) to 99.92% when pulling 5f2434484eb5992f953c880a360c23c60540a6f3 on sammyshj:usestemversion into a6efb2de1d876bed0c5f408ae9cf99e325b47513 on meejah:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.0%) to 99.92% when pulling 5f2434484eb5992f953c880a360c23c60540a6f3 on sammyshj:usestemversion into a6efb2de1d876bed0c5f408ae9cf99e325b47513 on meejah:master.

sambuddhabasu commented 9 years ago

@meejah I have added a new Tox environment with-stem. Do let me know if everything looks good so that I can go ahead and squash all the commits into one. Thanks

meejah commented 9 years ago

Yes, please squash it looks good so far :)

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.0%) to 99.92% when pulling 32f9d8e4716942593e1b472d624c98fff59be22c on sammyshj:usestemversion into a6efb2de1d876bed0c5f408ae9cf99e325b47513 on meejah:master.

sambuddhabasu commented 9 years ago

Done squashing the commits and the tests run good too :) Will this commit be merged with master or as you mentioned before with the stem-integration branch? Looks like the stem-integration branch is a whole lot of commits behind the master branch

meejah commented 9 years ago

Yeah, I tred rebasing stem-integration but it has a couple half-baked ideas so instead I'll create a new branch and merge this stuff into it. master is basically stable, and I think it's best to have a place we can try out more of the stem integration ideas together before trying to support a particular public API for it.

meejah commented 9 years ago

merged to optional-stem We can do integration there. Note that I took out the class-name check; if it acts like a stem Version object, that's good enough.