Generate valid_signals list dynamically

meejah / txtorcon

Twisted-based asynchronous Tor control protocol implementation. Includes unit-tests, examples, state-tracking code and configuration abstraction.

http://fjblvrw2jrxnhtg67qpbzi45r7ofojaoo3orzykesly2j3c2m3htapid.onion/

MIT License

250 stars 72 forks source link

Generate valid_signals list dynamically #115

Closed sambuddhabasu closed 9 years ago

sambuddhabasu commented 9 years ago

This PR is in continuation of #110

coveralls commented 9 years ago

Coverage increased (+0.0%) to 99.92% when pulling c5563481b3d40dcd237670545209048e3b0fec34 on sammyshj:validsignal into d89324a9bcfdbfe2a4dfdb5bde3dcaf23639e94e on meejah:master.

coveralls commented 9 years ago

Coverage increased (+0.0%) to 99.92% when pulling c51eb911191472c09f26493d7a11a3888a5a14aa on sammyshj:validsignal into d89324a9bcfdbfe2a4dfdb5bde3dcaf23639e94e on meejah:master.

sambuddhabasu commented 9 years ago

@meejah The code now handles only TorProtocolError. The test seems to be failing with pypy. Can you help me out with that?

sambuddhabasu commented 9 years ago

@meejah I have removed the RuntimeError from the except block. If the code looks good then should I squash the commits?

coveralls commented 9 years ago

Coverage increased (+0.0%) to 99.92% when pulling 8fc19ecb98da8760236037752f04908b4d89aa04 on sammyshj:validsignal into d89324a9bcfdbfe2a4dfdb5bde3dcaf23639e94e on meejah:master.

coveralls commented 9 years ago

Coverage increased (+0.0%) to 99.92% when pulling 8fc19ecb98da8760236037752f04908b4d89aa04 on sammyshj:validsignal into d89324a9bcfdbfe2a4dfdb5bde3dcaf23639e94e on meejah:master.

meejah commented 9 years ago

Yes, please squash

coveralls commented 9 years ago

Coverage increased (+0.0%) to 99.92% when pulling dcd29e81982045e7fe3d929e898186dfb5a2238c on sammyshj:validsignal into d89324a9bcfdbfe2a4dfdb5bde3dcaf23639e94e on meejah:master.

sambuddhabasu commented 9 years ago

@meejah This can be merged now :)

meejah commented 9 years ago

great, thanks!