protocol errors should be handled when router locations fail

meejah / txtorcon

Twisted-based asynchronous Tor control protocol implementation. Includes unit-tests, examples, state-tracking code and configuration abstraction.

http://fjblvrw2jrxnhtg67qpbzi45r7ofojaoo3orzykesly2j3c2m3htapid.onion/

MIT License

250 stars 72 forks source link

protocol errors should be handled when router locations fail #138

Closed meejah closed 9 years ago

meejah commented 9 years ago

See this OONI bug: https://trac.torproject.org/projects/tor/ticket/17320

If txtorcon resorts to asking Tor for a GeoIP location for a router and that fails, we should "do something sensible" (like set the location to (None, None)) and handle the Failure.

meejah commented 9 years ago

It seems this has was implemented in cad22ee9450aa0d72db19c31a9ffe502916ac09f included from v0.12.0 onwards. Must reconcile with the OONI problem...

meejah commented 9 years ago

ooniprobe works fine with latest txtorcon as far as Tor's 551 errors -- but other things in ooni fail without the GeoIP databases available.