Closed meejah closed 6 years ago
Does @david415 have an opinion on these? Am I missing anything?
Actually, it should just be OnionService
vs. AuthenticatedOnionService
I think; these both then have a list of clients (for non-stealth services, the hostname happens to be the same for each one, but the key will be different). They also need 3 things: hostname, and public/private key attrs.
That sounds good!
So far, the WIP branch for this is: https://github.com/meejah/txtorcon/compare/hidden-service-api.2
A new onion services API has landed on master
The current HiddenService API is inadequate to encapsulate all the hidden-service options. Which "should" be called Onion Services anyway.
Related tickets: #131, #96, #94
I propose adding a new API and interfaces to wrap over the issues mentioned in the above tickets (especially #131):
Unfortunately, I can't think of a way to make one interface/API adequate for "normal" services as well as stealth services, mainly because the latter have a different
.onion
hostname for each "client". For ephemeral vs. "normal" (disk-based) services, theIOnionService
is adequate. The following concrete classes would exist:APIs would be added to create these things (either methods on
TorConfig
, or methods requiring aTorConfig
instance).