search

meejah / txtorcon

Twisted-based asynchronous Tor control protocol implementation. Includes unit-tests, examples, state-tracking code and configuration abstraction.
http://fjblvrw2jrxnhtg67qpbzi45r7ofojaoo3orzykesly2j3c2m3htapid.onion/
MIT License
250 stars 72 forks source link

Add build_timeout_circuit helper function #148

Closed david415 closed 8 years ago

david415 commented 8 years ago

I still need to add tests and make sure the cancellation works as expected. Perhaps you'd like to code review it now?

meejah commented 8 years ago

Besides the minor signature changes etc, looks good, thanks :) So yes, please write some tests etc ;)

Also, it probably wants to be explicitly "exported" in the __all__ in __init__ which I mostly view as a "hint" as to public-API methods (I should be better about putting underscores in front of actually-private things, but that hasn't happened yet :/)

david415 commented 8 years ago

ok. i'll soon write some tests. as i've mentioned before... the errback needs to be added after the callback; so there's at least that one bug.

david415 commented 8 years ago

tests written

codecov-io commented 8 years ago

Current coverage is 99.69%

Merging #148 into master will not affect coverage as of bd198ce

@@            master    #148   diff @@
======================================
  Files           15      15       
  Stmts         2631    2644    +13
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           2623    2636    +13
  Partial          0       0       
  Missed           8       8

Review entire Coverage Diff as of bd198ce

Powered by Codecov. Updated on successful CI builds.

david415 commented 8 years ago

yay! all tests pass. please review.

meejah commented 8 years ago

Yup, looks great! Thanks :)