meejah / txtorcon

Twisted-based asynchronous Tor control protocol implementation. Includes unit-tests, examples, state-tracking code and configuration abstraction.
http://fjblvrw2jrxnhtg67qpbzi45r7ofojaoo3orzykesly2j3c2m3htapid.onion/
MIT License
250 stars 72 forks source link

Correct string unescaping #159

Closed coffeemakr closed 8 years ago

coffeemakr commented 8 years ago

It would good to implement a function to unescapes strings according to the descriptions in the control spec (2.2.1).

I tried to do this and define some tests.

codecov-io commented 8 years ago

Current coverage is 99.70%

Merging #159 into master will not affect coverage as of 64ed131

@@            master   #159   diff @@
=====================================
  Files           15     15       
  Stmts         2678   2685     +7
  Branches         0      0       
  Methods          0      0       
=====================================
+ Hit           2670   2677     +7
  Partial          0      0       
  Missed           8      8       

Review entire Coverage Diff as of 64ed131

Powered by Codecov. Updated on successful CI builds.

meejah commented 8 years ago

Great, thanks! This looks good, I'll test it locally against some Tor versions :)