meejah / txtorcon

Twisted-based asynchronous Tor control protocol implementation. Includes unit-tests, examples, state-tracking code and configuration abstraction.
http://fjblvrw2jrxnhtg67qpbzi45r7ofojaoo3orzykesly2j3c2m3htapid.onion/
MIT License
250 stars 72 forks source link

txsocksx not supported for python3 #162

Closed ghost closed 7 years ago

ghost commented 8 years ago

see https://github.com/habnabit/txsocksx/issues/16 Can't pip install txsocksx for python 3.4-3.5 While there are no issues encountered for python2.

Terminal output: error in txsocksx setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers; 'int' object is not iterable

meejah commented 8 years ago

This will mean no client-side support (e.g. TorClientEndpoint) for Python3 users until txsocksx is fixed. The only real solution here is to fix txsocksx (unless there's another quality Twisted SOCKS library I'm not aware of ;) )

david415 commented 8 years ago

ok... let's just write a SOCKS 5 client for txtorcon... or adapt a good enough twisted implementation. I think there are various good ones already written by i forget who exactly, perhaps Yawning or Linus from Tor Project. I also remember seeing some code in a twistedmatrix trac ticket.

meejah commented 8 years ago

Already done: https://github.com/meejah/txtorcon/blob/release-1.x/txtorcon/socks.py Probably needs more tests...

meejah commented 7 years ago

Now implemented in socks.py