make test fails on osx - Githubissues

meejah / txtorcon

Twisted-based asynchronous Tor control protocol implementation. Includes unit-tests, examples, state-tracking code and configuration abstraction.

http://fjblvrw2jrxnhtg67qpbzi45r7ofojaoo3orzykesly2j3c2m3htapid.onion/

MIT License

250 stars 72 forks source link

make test fails on osx #170

Closed kneufeld closed 7 years ago

kneufeld commented 8 years ago

requirements.txt was missing mock and geoip. my system didn't have geoip.h installed

coveralls commented 8 years ago

Coverage remained the same at 99.553% when pulling e95f6de3cafa67cfbcd1947dc5c470690dcd2c05 on kneufeld:master into bb2e0a19288ce7a0ee2fc82368344cdddfbc133d on meejah:master.

codecov-io commented 8 years ago

Current coverage is 99.55%

Merging #170 into master will not change coverage

@@           master    #170   diff @@
=====================================
  Files          15      15          
  Lines        2684    2684          
  Methods         0       0          
  Branches        0       0          
=====================================
  Hits         2672    2672          
  Misses         12      12          
  Partials        0       0

Powered by Codecov. Last updated by 9fd243d...1ce05af

coveralls commented 8 years ago

Coverage remained the same at 99.553% when pulling fbe2fc70cae00aa6228a2920ef048b282872dbab on kneufeld:master into 9fd243db31569c8c6b7dddec8f17fa8dd9ea9db7 on meejah:master.

meejah commented 7 years ago

Thanks! I cherry-picked the instructions commit as I think the combination of requirements + dev-requirements gets you a venv that you can run all the tests in. I believe that GeoIP is an optional dependency which is why it's only in "dev-requirements.txt".