Add support for NULL control port authentication

meejah / txtorcon

Twisted-based asynchronous Tor control protocol implementation. Includes unit-tests, examples, state-tracking code and configuration abstraction.

http://fjblvrw2jrxnhtg67qpbzi45r7ofojaoo3orzykesly2j3c2m3htapid.onion/

MIT License

250 stars 72 forks source link

Add support for NULL control port authentication #175

Closed david415 closed 8 years ago

david415 commented 8 years ago

https://github.com/meejah/txtorcon/issues/174

coveralls commented 8 years ago

Coverage decreased (-0.1%) to 99.405% when pulling a768133909f627cb019530f3cb3250aa0814801a on david415:174.add_null_control_auth.0 into 9fd243db31569c8c6b7dddec8f17fa8dd9ea9db7 on meejah:master.

codecov-io commented 8 years ago

Current coverage is 99.55%

No coverage report found for master at 9fd243d.

Powered by Codecov. Last updated by 9fd243d...4fba599

meejah commented 8 years ago

Patch looks fine -- I'm curious why codecov is showing the main block of the if "NULL"... as uncovered though ... I'll try locally.

meejah commented 8 years ago

Locally, it shows 100% coverage. Thanks for the patch!

meejah commented 8 years ago

p.s. do you want to add a note to releases.rst before I merge?

david415 commented 8 years ago

ok i added a note to the releases.rst

coveralls commented 8 years ago

Coverage increased (+0.0008%) to 99.554% when pulling 4fba599f7477c57a306498847ab6999ea2ad4b69 on david415:174.add_null_control_auth.0 into 9fd243db31569c8c6b7dddec8f17fa8dd9ea9db7 on meejah:master.

coveralls commented 8 years ago

Coverage decreased (-0.07%) to 99.479% when pulling 4fba599f7477c57a306498847ab6999ea2ad4b69 on david415:174.add_null_control_auth.0 into 9fd243db31569c8c6b7dddec8f17fa8dd9ea9db7 on meejah:master.

meejah commented 8 years ago

Perfect, thanks :)