Add socks_endpoint kwarg to TorClientEndpoint's constructor

meejah / txtorcon

Twisted-based asynchronous Tor control protocol implementation. Includes unit-tests, examples, state-tracking code and configuration abstraction.

http://fjblvrw2jrxnhtg67qpbzi45r7ofojaoo3orzykesly2j3c2m3htapid.onion/

MIT License

250 stars 72 forks source link

Add socks_endpoint kwarg to TorClientEndpoint's constructor #182

Closed david415 closed 8 years ago

david415 commented 8 years ago

this adds UNIX domain socket functionality to the TorClientEndpoint... so that we connect to the SOCKS proxy via a unix domain socket.

coveralls commented 8 years ago

Coverage decreased (-0.2%) to 99.338% when pulling 3cc23fce9915a3ca882e56ceadf2b6e015ada075 on david415:181.unix_socks.0 into 24d4aa248e647b76aeb33b53c88dec5c2116d60a on meejah:master.

coveralls commented 8 years ago

Coverage decreased (-0.2%) to 99.338% when pulling 3cc23fce9915a3ca882e56ceadf2b6e015ada075 on david415:181.unix_socks.0 into 24d4aa248e647b76aeb33b53c88dec5c2116d60a on meejah:master.

coveralls commented 8 years ago

Coverage decreased (-0.2%) to 99.338% when pulling 3cc23fce9915a3ca882e56ceadf2b6e015ada075 on david415:181.unix_socks.0 into 24d4aa248e647b76aeb33b53c88dec5c2116d60a on meejah:master.

coveralls commented 8 years ago

Coverage decreased (-0.2%) to 99.338% when pulling 3cc23fce9915a3ca882e56ceadf2b6e015ada075 on david415:181.unix_socks.0 into 24d4aa248e647b76aeb33b53c88dec5c2116d60a on meejah:master.

codecov-io commented 8 years ago

Current coverage is 99.41% (diff: 88.88%)

Merging #182 into master will decrease coverage by 0.14%

@@             master       #182   diff @@
==========================================
  Files            15         15          
  Lines          2709       2724    +15   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           2697       2708    +11   
- Misses           12         16     +4   
  Partials          0          0

Powered by Codecov. Last update 24d4aa2...6e85838

coveralls commented 8 years ago

Coverage decreased (-0.2%) to 99.374% when pulling 594e8edc2ac94e8f9b1e40b47756c665d6d4e5e2 on david415:181.unix_socks.0 into 24d4aa248e647b76aeb33b53c88dec5c2116d60a on meejah:master.

coveralls commented 8 years ago

Coverage decreased (-0.1%) to 99.411% when pulling 7682481a4ff38ba6acf476125c45d24114897e7b on david415:181.unix_socks.0 into 24d4aa248e647b76aeb33b53c88dec5c2116d60a on meejah:master.

coveralls commented 8 years ago

Coverage increased (+0.001%) to 99.558% when pulling 31a46dddb4c1afc09d7723dc01dd72942bd12398 on david415:181.unix_socks.0 into 24d4aa248e647b76aeb33b53c88dec5c2116d60a on meejah:master.

coveralls commented 8 years ago

Coverage increased (+0.001%) to 99.558% when pulling 31a46dddb4c1afc09d7723dc01dd72942bd12398 on david415:181.unix_socks.0 into 24d4aa248e647b76aeb33b53c88dec5c2116d60a on meejah:master.

coveralls commented 8 years ago

Coverage increased (+0.001%) to 99.558% when pulling 31a46dddb4c1afc09d7723dc01dd72942bd12398 on david415:181.unix_socks.0 into 24d4aa248e647b76aeb33b53c88dec5c2116d60a on meejah:master.

coveralls commented 8 years ago

Coverage increased (+0.001%) to 99.558% when pulling 31a46dddb4c1afc09d7723dc01dd72942bd12398 on david415:181.unix_socks.0 into 24d4aa248e647b76aeb33b53c88dec5c2116d60a on meejah:master.

meejah commented 8 years ago

Cool, looks good. Should probably have a test for the backwards-compat thing I guess ...

david415 commented 8 years ago

I tested it! It works. I tested with tor configured with a unix socket SOCKS port...

coveralls commented 8 years ago

Coverage decreased (-0.1%) to 99.413% when pulling 6e85838af928f8c16d2f7749568a4aec5902be80 on david415:181.unix_socks.0 into 24d4aa248e647b76aeb33b53c88dec5c2116d60a on meejah:master.

coveralls commented 8 years ago

Coverage decreased (-0.1%) to 99.413% when pulling 6e85838af928f8c16d2f7749568a4aec5902be80 on david415:181.unix_socks.0 into 24d4aa248e647b76aeb33b53c88dec5c2116d60a on meejah:master.

meejah commented 8 years ago

Oh, hmm: need tests for the if self.tls cases too...

meejah commented 8 years ago

Superceded by #183 (so that I don't have to wait for @david415 to merge my moar-commits to his branch etc).