meejah / txtorcon

Twisted-based asynchronous Tor control protocol implementation. Includes unit-tests, examples, state-tracking code and configuration abstraction.
http://fjblvrw2jrxnhtg67qpbzi45r7ofojaoo3orzykesly2j3c2m3htapid.onion/
MIT License
250 stars 72 forks source link

Addrmap stream improvement #184

Closed meejah closed 8 years ago

meejah commented 8 years ago

Using list-comprehensions to do the notifications might look nice, but isn't very robust.

Also, re-map Stream.target_host from IP back to hostname, whenever possible (should be "always").

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.1%) to 99.381% when pulling 68e21ce709ea37b1deaf0c7cfb5128ac283167e4 on addrmap-stream-improvement into d737c35dd604c17bbb01a6fe4dccfac7c054d8eb on master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.1%) to 99.381% when pulling 68e21ce709ea37b1deaf0c7cfb5128ac283167e4 on addrmap-stream-improvement into d737c35dd604c17bbb01a6fe4dccfac7c054d8eb on master.

codecov-io commented 8 years ago

Current coverage is 99.54% (diff: 100%)

Merging #184 into master will increase coverage by 0.01%

@@             master       #184   diff @@
==========================================
  Files            15         15          
  Lines          2731       2836   +105   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           2718       2823   +105   
  Misses           13         13          
  Partials          0          0          

Powered by Codecov. Last update d737c35...25ed60c

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.1%) to 99.382% when pulling 9ea4729201d4fbc3e7468352bed0f07dee7f640d on addrmap-stream-improvement into d737c35dd604c17bbb01a6fe4dccfac7c054d8eb on master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.003%) to 99.527% when pulling 25ed60c9dd1233471f389aab2df1f30728e61a7e on addrmap-stream-improvement into d737c35dd604c17bbb01a6fe4dccfac7c054d8eb on master.