Attacher API

[meejah]

Merge the new "put a stream on a specific circuit" APIs from release-1.x which basically side-steps the set_attacher stuff.

New code (that's not on release-1.x) and is required:

• [x] "soft-deprecate" / discourage (public) use of set_attacher API
• [x] make it an error to use both APIs at once
• [x] add "PriorityAttacher" or similar, so you get an add/remote attacher API without changing "the" API

After the doc changes are merged, they should be upgraded to discuss all the issues with attachment (that is that Tor doesn't deal properly with > 1 controller being an attacher).

[codecov-io]

Codecov Report

Merging #207 into master will increase coverage by <.01%.

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   99.88%   99.88%   +<.01%     
==========================================
  Files          18       19       +1     
  Lines        3374     3485     +111     
==========================================
+ Hits         3370     3481     +111     
  Misses          4        4

Impacted Files	Coverage Δ
txtorcon/torstate.py	100% <100%> (ø)	:white_check_mark:
txtorcon/web.py	100% <100%> (ø)	:white_check_mark:
txtorcon/endpoints.py	100% <100%> (ø)	:white_check_mark:
txtorcon/socks.py	100% <100%> (ø)	:white_check_mark:
txtorcon/circuit.py	100% <100%> (ø)	:white_check_mark:
txtorcon/util.py	98.12% <100%> (ø)	:white_check_mark:
txtorcon/attacher.py	100% <100%> (ø)
txtorcon/interface.py	100% <100%> (ø)	:white_check_mark:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 994c594...3abfdfd. Read the comment docs.

[coveralls]

Coverage increased (+0.002%) to 99.883% when pulling 2fc8902b0a3e77b83e4646d51d47cdc8e94f303b on attacher-api into 0a1fc134e203dedc5b9b1bcde8deda2ab5776595 on master.

[coveralls]

Coverage increased (+0.002%) to 99.883% when pulling 2fc8902b0a3e77b83e4646d51d47cdc8e94f303b on attacher-api into 0a1fc134e203dedc5b9b1bcde8deda2ab5776595 on master.

[coveralls]

Coverage increased (+0.002%) to 99.883% when pulling 2fc8902b0a3e77b83e4646d51d47cdc8e94f303b on attacher-api into 0a1fc134e203dedc5b9b1bcde8deda2ab5776595 on master.

[coveralls]

Coverage increased (+0.002%) to 99.883% when pulling 2fc8902b0a3e77b83e4646d51d47cdc8e94f303b on attacher-api into 0a1fc134e203dedc5b9b1bcde8deda2ab5776595 on master.

[coveralls]

Coverage increased (+0.002%) to 99.883% when pulling 2fc8902b0a3e77b83e4646d51d47cdc8e94f303b on attacher-api into 0a1fc134e203dedc5b9b1bcde8deda2ab5776595 on master.

[coveralls]

Coverage increased (+0.002%) to 99.883% when pulling 2fc8902b0a3e77b83e4646d51d47cdc8e94f303b on attacher-api into 0a1fc134e203dedc5b9b1bcde8deda2ab5776595 on master.

[meejah]

has @coveralls lost its mind?

[coveralls]

Coverage decreased (-0.08%) to 99.797% when pulling 6eface34461c80768dd7b00a7bccb85183ac2ce4 on attacher-api into 994c5940b325429642dc6e6978d7cafc5729b181 on master.

[coveralls]

Coverage increased (+0.003%) to 99.884% when pulling aae75784e59ec998ca09ba2ca6776fe23fb5f291 on attacher-api into 994c5940b325429642dc6e6978d7cafc5729b181 on master.

[coveralls]

Coverage increased (+0.004%) to 99.885% when pulling 1cc29e5f2d0900b25f0a7c7abad09eae6381f840 on attacher-api into 994c5940b325429642dc6e6978d7cafc5729b181 on master.

[coveralls]

Coverage increased (+0.004%) to 99.885% when pulling 1cc29e5f2d0900b25f0a7c7abad09eae6381f840 on attacher-api into 994c5940b325429642dc6e6978d7cafc5729b181 on master.

[coveralls]

Coverage increased (+0.004%) to 99.885% when pulling 1cc29e5f2d0900b25f0a7c7abad09eae6381f840 on attacher-api into 994c5940b325429642dc6e6978d7cafc5729b181 on master.

[coveralls]

Coverage increased (+0.004%) to 99.885% when pulling 1cc29e5f2d0900b25f0a7c7abad09eae6381f840 on attacher-api into 994c5940b325429642dc6e6978d7cafc5729b181 on master.

[coveralls]

Coverage increased (+0.004%) to 99.885% when pulling 1cc29e5f2d0900b25f0a7c7abad09eae6381f840 on attacher-api into 994c5940b325429642dc6e6978d7cafc5729b181 on master.

[coveralls]

Coverage increased (+0.004%) to 99.885% when pulling 3abfdfd28568da47497e96bf1a48d6a3d303178b on attacher-api into 994c5940b325429642dc6e6978d7cafc5729b181 on master.

[coveralls]

Coverage increased (+0.004%) to 99.885% when pulling 3abfdfd28568da47497e96bf1a48d6a3d303178b on attacher-api into 994c5940b325429642dc6e6978d7cafc5729b181 on master.

[coveralls]

Coverage increased (+0.004%) to 99.885% when pulling 3abfdfd28568da47497e96bf1a48d6a3d303178b on attacher-api into 994c5940b325429642dc6e6978d7cafc5729b181 on master.

[coveralls]

Coverage increased (+0.004%) to 99.885% when pulling 3abfdfd28568da47497e96bf1a48d6a3d303178b on attacher-api into 994c5940b325429642dc6e6978d7cafc5729b181 on master.

[coveralls]

Coverage increased (+0.004%) to 99.885% when pulling 3abfdfd28568da47497e96bf1a48d6a3d303178b on attacher-api into 994c5940b325429642dc6e6978d7cafc5729b181 on master.

[coveralls]

Coverage increased (+0.004%) to 99.885% when pulling 3abfdfd28568da47497e96bf1a48d6a3d303178b on attacher-api into 994c5940b325429642dc6e6978d7cafc5729b181 on master.

[meejah]

squash-merged as https://github.com/meejah/txtorcon/commit/080262391d4cf617ccd8b6ad7d72282447cc5c01