Closed felipedau closed 7 years ago
Merging #219 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #219 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 20 20
Lines 3566 3566
=======================================
Hits 3562 3562
Misses 4 4
Impacted Files | Coverage Δ | |
---|---|---|
txtorcon/torconfig.py | 100% <100%> (ø) |
:white_check_mark: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 959f6ac...be8bcc2. Read the comment docs.
Yeah, your fix is probably good. See also: https://trac.torproject.org/projects/tor/ticket/20956#comment:25
(personally I think they should just keep the original spelling to avoid breaking things, but hey ;)
See also: https://trac.torproject.org/projects/tor/ticket/20956#comment:25
Oh thanks, very interesting!
(personally I think they should just keep the original spelling to avoid breaking things, but hey ;)
I agree - good thing it is very easy to fix. A bigger problem is when an expected LineList
becomes Depend[ae]nt
:P
Thanks!
As I was reading the specs recently, I noticed the following note and thought it wouldn't hurt to add this other conditional.
Could this be useful?