meejah / txtorcon

Twisted-based asynchronous Tor control protocol implementation. Includes unit-tests, examples, state-tracking code and configuration abstraction.

http://fjblvrw2jrxnhtg67qpbzi45r7ofojaoo3orzykesly2j3c2m3htapid.onion/

MIT License

250 stars 72 forks source link

When closed when built #231

Closed meejah closed 7 years ago

coveralls commented 7 years ago

Coverage decreased (-0.08%) to 99.863% when pulling c4fed93f928e1af6622348e1db4852f0dc13b78f on when_closed_when_built into 7157e386a7041207171b374e1766c402c7ee03bf on master.

codecov-io commented 7 years ago

Codecov Report

Merging #231 into master will decrease coverage by <.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
- Coverage   99.94%   99.94%   -0.01%     
==========================================
  Files          20       20              
  Lines        3657     3656       -1     
==========================================
- Hits         3655     3654       -1     
  Misses          2        2

Impacted Files	Coverage Δ
txtorcon/circuit.py	`100% <100%> (ø)`	:arrow_up:
txtorcon/torstate.py	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 775d2ea...8c57b14. Read the comment docs.

coveralls commented 7 years ago

Coverage decreased (-1.0e-05%) to 99.945% when pulling 8c57b147a17ee0f3979d09e5dc2573e2b3cb80cb on when_closed_when_built into 775d2ea24c8d42e316cb811f7daf5b3419cb40a8 on master.

coveralls commented 7 years ago

Coverage decreased (-1.0e-05%) to 99.945% when pulling 8c57b147a17ee0f3979d09e5dc2573e2b3cb80cb on when_closed_when_built into 775d2ea24c8d42e316cb811f7daf5b3419cb40a8 on master.

coveralls commented 7 years ago

Coverage decreased (-1.0e-05%) to 99.945% when pulling 8c57b147a17ee0f3979d09e5dc2573e2b3cb80cb on when_closed_when_built into 775d2ea24c8d42e316cb811f7daf5b3419cb40a8 on master.

coveralls commented 7 years ago

Coverage decreased (-1.0e-05%) to 99.945% when pulling 8c57b147a17ee0f3979d09e5dc2573e2b3cb80cb on when_closed_when_built into 775d2ea24c8d42e316cb811f7daf5b3419cb40a8 on master.

coveralls commented 7 years ago

Coverage decreased (-1.0e-05%) to 99.945% when pulling 8c57b147a17ee0f3979d09e5dc2573e2b3cb80cb on when_closed_when_built into 775d2ea24c8d42e316cb811f7daf5b3419cb40a8 on master.

coveralls commented 7 years ago

Coverage decreased (-1.0e-05%) to 99.945% when pulling 8c57b147a17ee0f3979d09e5dc2573e2b3cb80cb on when_closed_when_built into 775d2ea24c8d42e316cb811f7daf5b3419cb40a8 on master.

coveralls commented 7 years ago

Coverage decreased (-1.0e-05%) to 99.945% when pulling 8c57b147a17ee0f3979d09e5dc2573e2b3cb80cb on when_closed_when_built into 775d2ea24c8d42e316cb811f7daf5b3419cb40a8 on master.

coveralls commented 7 years ago

Coverage decreased (-1.0e-05%) to 99.945% when pulling 8c57b147a17ee0f3979d09e5dc2573e2b3cb80cb on when_closed_when_built into 775d2ea24c8d42e316cb811f7daf5b3419cb40a8 on master.

coveralls commented 7 years ago

Coverage decreased (-1.0e-05%) to 99.945% when pulling 8c57b147a17ee0f3979d09e5dc2573e2b3cb80cb on when_closed_when_built into 775d2ea24c8d42e316cb811f7daf5b3419cb40a8 on master.

meejah commented 7 years ago

I don't understand why coveralls and codecov believe there is less overall coverage (nor how that could possibly have happened with this patch...)