meejah / txtorcon

Twisted-based asynchronous Tor control protocol implementation. Includes unit-tests, examples, state-tracking code and configuration abstraction.

http://fjblvrw2jrxnhtg67qpbzi45r7ofojaoo3orzykesly2j3c2m3htapid.onion/

MIT License

250 stars 72 forks source link

Make ipaddress a conditional dependency. (Closes: #247) #259

Closed hlieberman closed 6 years ago

hlieberman commented 6 years ago

Note, this requires a build version of setuptools greater than 36.2.

coveralls commented 6 years ago

Coverage remained the same at 99.946% when pulling 86f4bfc6434f7c05efa5a2d1e112c80b7ae5ff4d on hlieberman:conditional-dependency into d13d37a34cac4f028df0287dd13536ef11525a2a on meejah:master.

codecov-io commented 6 years ago

Codecov Report

Merging #259 into master will increase coverage by 0.05%. The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #259      +/-   ##
========================================
+ Coverage   99.94%   100%   +0.05%     
========================================
  Files          20     18       -2     
  Lines        3713   3449     -264     
========================================
- Hits         3711   3449     -262     
+ Misses          2      0       -2

Impacted Files	Coverage Δ
txtorcon/util.py
docs/_themes/alabaster/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d13d37a...ce0e471. Read the comment docs.

hlieberman commented 6 years ago

I suspect the codecov thing is a false positive; I can't imagine it changing the coverage at all, unless it's measuring the coverage in the dependencies (which would be a bad idea).

hlieberman commented 6 years ago

@meejah, it should work, but... documentation on this functionality is, let's say, "sparse". I'd imagine it would simply either pin/hash the dependency or not, depending on whether you were using py2 or py3. The PEP doesn't specify the behavior, though, and neither does setuptools' docs. So, I'm just guessing.

Added the setup_depends!

coveralls commented 6 years ago

Coverage remained the same at 99.946% when pulling ce0e4713ce6f2fca08c7f5ef33cdc8231515414d on hlieberman:conditional-dependency into d13d37a34cac4f028df0287dd13536ef11525a2a on meejah:master.

coveralls commented 6 years ago

meejah commented 6 years ago

Great, thanks!

(...and yes, in my experience codecov "often" thinks things aren't covered in PRs for some reason I don't care to debug)

meejah commented 6 years ago

Merged; thanks for the PR!