meejah / txtorcon

Twisted-based asynchronous Tor control protocol implementation. Includes unit-tests, examples, state-tracking code and configuration abstraction.
http://fjblvrw2jrxnhtg67qpbzi45r7ofojaoo3orzykesly2j3c2m3htapid.onion/
MIT License
250 stars 72 forks source link

python-ipaddr is not optional #30

Closed webmeister closed 11 years ago

webmeister commented 11 years ago

The README lists python-ipaddr as an optional dependency. txtorcon/stream.py however imports ipaddr without any fallback, so trying to use txtorcon without python-ipaddr fails:

Traceback (most recent call last):
  File "/usr/share/txtorcon/examples/dump_config.py", line 18, in 
    from txtorcon import TorProtocolFactory, TorConfig, DEFAULT_VALUE
  File "/usr/lib/python2.7/site-packages/txtorcon/__init__.py", line 13, in 
    from txtorcon.stream import Stream
  File "/usr/lib/python2.7/site-packages/txtorcon/stream.py", line 14, in 
    import ipaddr
ImportError: No module named ipaddr
meejah commented 11 years ago

Thanks for the report! It should now be actually-optional...