meejah / txtorcon

Twisted-based asynchronous Tor control protocol implementation. Includes unit-tests, examples, state-tracking code and configuration abstraction.
http://fjblvrw2jrxnhtg67qpbzi45r7ofojaoo3orzykesly2j3c2m3htapid.onion/
MIT License
250 stars 72 forks source link

Ephemeral server endpoint logs incorrect listening address #307

Closed exarkun closed 6 years ago

exarkun commented 6 years ago

On running:

twistd web --listen onion:12345

The following is eventually logged:

2018-07-16T12:57:10-0400 [TorControlProtocol,client] Started hidden service port 12345
2018-07-16T12:57:10-0400 [TorControlProtocol,client]   listening on <REDACTED>.onion.onion

Note the .onion.onion suffix (which should instead be .onion - just once)

meejah commented 6 years ago

Hmm, what version was this with? 18.0.2 and higher have mostly-new onion code, I see the following when running twistd:

2018-07-17T13:05:57-0600 [TorControlProtocol,client] 77% Finishing handshake with first hop
2018-07-17T13:05:57-0600 [TorControlProtocol,client] 81% Establishing a Tor circuit
2018-07-17T13:05:57-0600 [TorControlProtocol,client] 90% Done
2018-07-17T13:05:57-0600 [TorControlProtocol,client] Site starting on 42955
2018-07-17T13:05:57-0600 [twisted.web.server.Site#info] Starting factory <twisted.web.server.Site object at 0x7f178a91b7f0>
2018-07-17T13:05:57-0600 [TorControlProtocol,client] 4krfsxfmr3hqewze.onion: waiting for descriptor uploads.
2018-07-17T13:06:31-0600 [TorControlProtocol,client] Uploaded '4krfsxfmr3hqewze' to '$A5831AB5C289707A179802A7923B3535C812069E~IbShoit2hanuDa'
2018-07-17T13:06:31-0600 [TorControlProtocol,client] Started onion service on 4krfsxfmr3hqewze.onion:12345
exarkun commented 6 years ago

Ugh. Sorry. Somehow I ended up with a very old version. With 18.0.2 I see the same correct behavior as you.