rbalint commented 6 years ago

On Ubuntu we don't ship controller_py3.py for Python 2.7 because parsing it during installation breaks the installation. The missing file triggers ModuleNotFoundError instead of SyntaxError and IMO catching Exception and continuing with no async is semantically as correct as listing the potential subclasses.

codecov-io commented 6 years ago

Codecov Report

Merging #309 into master will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #309   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          21     21           
  Lines        4326   4326           
=====================================
  Hits         4326   4326

Impacted Files	Coverage Δ
txtorcon/controller.py	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0d3e958...c160531. Read the comment docs.

coveralls commented 6 years ago

Coverage remained the same at 99.957% when pulling c160531e885a3695ec1627070b6f48dfc443f3c8 on rbalint:master into 0d3e95887e5a126b12c1bf1a49870bb6ef02e0cf on meejah:master.

meejah commented 6 years ago

Great, sounds fine with me, thanks for the PR! :)

meejah / txtorcon

figure out if we have async in an even more robust way #309

Codecov Report