search

meejah / txtorcon

Twisted-based asynchronous Tor control protocol implementation. Includes unit-tests, examples, state-tracking code and configuration abstraction.
http://fjblvrw2jrxnhtg67qpbzi45r7ofojaoo3orzykesly2j3c2m3htapid.onion/
MIT License
250 stars 72 forks source link

TCPHiddenServiceEndpointParser.parseStreamServer drops privateKey argument on the floor #314

Closed exarkun closed 5 years ago

exarkun commented 6 years ago

It looks like you're supposed to be able to supply a privateKey to the onion:... endpoint server string parser. And you can supply it - but it's not used for anything (apart from checking for conflicting with a hiddenServiceDir value). The net result is that when passing a privateKey, you always get a newly allocated key from the Tor daemon, I think.

exarkun commented 6 years ago

I tried to use TCPHiddenServiceEndpointParser to implement another endpoint that works with a privateKeyPath instead. I wanted to do this to avoid duplicating the control port handling code in TCPHiddenServiceEndpointParser (and some other minor logic). The privateKey handling seems to preclude this possibility though, at least for now.

meejah commented 5 years ago

This appears to have been fixed in 89062746cd245ffda4788b5b4696d4469514e45c (which was first released in v18.2.0 according to a git incantation).