search

meejah / txtorcon

Twisted-based asynchronous Tor control protocol implementation. Includes unit-tests, examples, state-tracking code and configuration abstraction.
http://fjblvrw2jrxnhtg67qpbzi45r7ofojaoo3orzykesly2j3c2m3htapid.onion/
MIT License
250 stars 72 forks source link

non anonymous services #317

Closed meejah closed 6 years ago

meejah commented 6 years ago

See #315

"launch()" should probably support the right option(s) too, but .. tor doesn't bootstrap if you start it with the two relevant options but without any Onion Services defined on the command-line as well (see https://github.com/meejah/txtorcon/pull/318 for that implementation thus far).

See https://trac.torproject.org/projects/tor/ticket/27849 which is the "tor doesn't bootstrap" bug described above.

codecov-io commented 6 years ago

Codecov Report

Merging #317 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #317   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          21     21           
  Lines        4355   4362    +7     
=====================================
+ Hits         4355   4362    +7
Impacted Files Coverage Δ
txtorcon/onion.py 100% <100%> (ø) :arrow_up:
txtorcon/endpoints.py 100% <100%> (ø) :arrow_up:
txtorcon/controller.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a508b38...e666333. Read the comment docs.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+6.0e-05%) to 99.957% when pulling e6663331f3c6ca0ec90ffbdae47e905b55eb3cb1 on ticket315-non-anonymous-services into a508b385ca8c7efce486bdea048e0ab81331fdc7 on master.

meejah commented 6 years ago

p.s. willing to bikeshed on the name of single_hop= kwarg. e.g. maybe non_anonymous=True is better? (but also: double-negative). Logically maybe anonymous=True as the default, and you can set anonymous=False to trigger the new behavior?