meejah / txtorcon

Twisted-based asynchronous Tor control protocol implementation. Includes unit-tests, examples, state-tracking code and configuration abstraction.
http://fjblvrw2jrxnhtg67qpbzi45r7ofojaoo3orzykesly2j3c2m3htapid.onion/
MIT License
250 stars 72 forks source link

Ticket226 control port status #323

Closed glowatsk closed 5 years ago

glowatsk commented 5 years ago

Easy enough start to check for 'Opening Control listener' over checking every line for bootstrap. Edited the tests. Next steps could be parsing only a few lines?

Do we need to error handle when control port is not set?

Thanks

codecov-io commented 5 years ago

Codecov Report

Merging #323 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #323   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          21     21           
  Lines        4369   4369           
=====================================
  Hits         4369   4369
Impacted Files Coverage Δ
txtorcon/controller.py 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5cac1df...8c66662. Read the comment docs.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 99.957% when pulling 8c666628b2ccc6dae4371c0f869f0c913188618c on glowatsk:ticket226-control-port-status into 5cac1dfa176a255f041c4158b750aec89dd2f379 on meejah:master.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 99.957% when pulling 8c666628b2ccc6dae4371c0f869f0c913188618c on glowatsk:ticket226-control-port-status into 5cac1dfa176a255f041c4158b750aec89dd2f379 on meejah:master.