meejah / txtorcon

Twisted-based asynchronous Tor control protocol implementation. Includes unit-tests, examples, state-tracking code and configuration abstraction.
http://fjblvrw2jrxnhtg67qpbzi45r7ofojaoo3orzykesly2j3c2m3htapid.onion/
MIT License
250 stars 72 forks source link

Tests fail due to missing file 'release-announce-test' #330

Open lfam opened 5 years ago

lfam commented 5 years ago

While packaging txtorcon 19.0.0 for Guix, I found that txtorcon's test suite fails when it can't find the file release-announce-test in the unpacked source code as downloaded from PyPi.

Specifically, it fails like this:

running test
running egg_info
writing txtorcon.egg-info/PKG-INFO
writing dependency_links to txtorcon.egg-info/dependency_links.txt
writing requirements to txtorcon.egg-info/requires.txt
writing top-level names to txtorcon.egg-info/top_level.txt
package init file 'twisted/plugins/__init__.py' not found (or not a regular file)
reading manifest file 'txtorcon.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no previously-included files found matching 'docs/_static/*~'
warning: no previously-included files found matching 'docs/_themes/*~'
warning: no previously-included files found matching 'docs/_themes/alabaster/*~'
warning: no previously-included files found matching 'docs/_themes/alabaster/*.pyc'
warning: no previously-included files found matching 'docs/_themes/alabaster/static/*~'
warning: no previously-included files found matching 'examples/*~'
writing manifest file 'txtorcon.egg-info/SOURCES.txt'
running build_ext
no announcement file: /tmp/guix-build-python-txtorcon-19.0.0.drv-0/txtorcon-19.0.0/test/../release-announce-test
Backtrace:
           5 (primitive-load "/gnu/store/bc85mxvb1afvx6nl84jyw2v9273…")
In ice-9/eval.scm:
   191:35  4 (_ _)
In srfi/srfi-1.scm:
   863:16  3 (every1 #<procedure 71a9c0 at /gnu/store/4r04fsfcryy5h…> …)
In /gnu/store/4r04fsfcryy5h4v2h3g6lzlibafmmdjm-module-import/guix/build/gnu-build-system.scm:
   799:28  2 (_ _)
In /gnu/store/4r04fsfcryy5h4v2h3g6lzlibafmmdjm-module-import/guix/build/python-build-system.scm:
    142:8  1 (check #:tests? _ #:test-target _ #:use-setuptools? _)
In /gnu/store/4r04fsfcryy5h4v2h3g6lzlibafmmdjm-module-import/guix/build/utils.scm:
    616:6  0 (invoke _ . _)

/gnu/store/4r04fsfcryy5h4v2h3g6lzlibafmmdjm-module-import/guix/build/utils.scm:616:6: In procedure invoke:
Throw to key `srfi-34' with args `(#<condition &invoke-error [program: "python" arguments: ("-c" "import setuptools, tokenize;__file__='setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\\r\\n', '\\n');f.close();exec(compile(code, __file__, 'exec'))" "test") exit-status: 2 term-signal: #f stop-signal: #f] 56dec0>)'.
builder for `/gnu/store/hdsbdcyp0lwc80s3rahmz7pnmbm3mwlx-python-txtorcon-19.0.0.drv' failed with exit code 1
build of /gnu/store/hdsbdcyp0lwc80s3rahmz7pnmbm3mwlx-python-txtorcon-19.0.0.drv failed

Am I running the tests correctly? Are they intended to be run by downstream distributors?

meejah commented 4 years ago

Hmm, I can't find the string release-announce-test in the source (.tar.gz) for 19.0.0 (nor in my Git repo). While I didn't necessarily intend for people to download and run the tests like that, it should still work.

Thanks for packaging! (Sorry for the delay responding to this)