meejah / txtorcon

Twisted-based asynchronous Tor control protocol implementation. Includes unit-tests, examples, state-tracking code and configuration abstraction.
http://fjblvrw2jrxnhtg67qpbzi45r7ofojaoo3orzykesly2j3c2m3htapid.onion/
MIT License
249 stars 72 forks source link

All of test.test_util is skipped #352

Closed exarkun closed 3 years ago

exarkun commented 3 years ago

From a recent run on GitHub Actions:

  [SKIPPED]
  <function skip at 0x7f545afd9820>

  test.test_util.TestDefaultPort.test_env_var
  test.test_util.TestDefaultPort.test_no_env_var
  test.test_util.TestDelete.test_delete_file
  test.test_util.TestDelete.test_delete_tree
  test.test_util.TestFakeControlProtocol.test_happened_already
  test.test_util.TestFakeControlProtocol.test_happens
  test.test_util.TestFindKeywords.test_filter
  test.test_util.TestFindTor.test_find_ioerror
  test.test_util.TestFindTor.test_find_tor_globs
  test.test_util.TestFindTor.test_find_tor_unfound
  test.test_util.TestFindTor.test_simple_find_tor
  test.test_util.TestGeoIpDatabaseLoading.test_bad_geoip_path
  test.test_util.TestGeoIpDatabaseLoading.test_missing_geoip_module
  test.test_util.TestGeoIpDatabaseLoading.test_return_geoip_object
  test.test_util.TestHeaders.test_simple
  test.test_util.TestIpAddr.test_create_ipaddr
  test.test_util.TestIpAddr.test_create_ipaddr_fail
  test.test_util.TestListeners.test_add_remove
  test.test_util.TestListeners.test_collection
  test.test_util.TestListeners.test_collection_invalid_event
  test.test_util.TestListeners.test_collection_invalid_event_notify
  test.test_util.TestListeners.test_collection_invalid_event_remove
  test.test_util.TestListeners.test_notify_with_exception
  test.test_util.TestNetLocation.test_city_fails
  test.test_util.TestNetLocation.test_no_city_db
  test.test_util.TestNetLocation.test_no_city_or_country_db
  test.test_util.TestNetLocation.test_valid_lookup_v2
  test.test_util.TestNetLocation.test_valid_lookup_v3
  test.test_util.TestProcessFromUtil.test_internal
  test.test_util.TestProcessFromUtil.test_internal_no_state
  test.test_util.TestProcessFromUtil.test_none
  test.test_util.TestProcessFromUtil.test_real_addr
  test.test_util.TestUnescapeQuotedString.test_invalid_string_unescaping
  test.test_util.TestUnescapeQuotedString.test_string_unescape_octals
  test.test_util.TestUnescapeQuotedString.test_valid_string_unescaping
  test.test_util.TestVersions.test_version_1
  test.test_util.TestVersions.test_version_2
  test.test_util.TestVersions.test_version_3
  test.test_util.TestVersions.test_version_4
  test.test_util.TestVersions.test_version_big

The cause is from unittest import skip. trial interprets the skip name to mean the whole module should be skipped.

meejah commented 3 years ago

The cause is from unittest import skip. trial interprets the skip name to mean the whole module should be skipped.

Arg, what? Well, that's ... surprising. Thanks for the patches!