search

meejah / txtorcon

Twisted-based asynchronous Tor control protocol implementation. Includes unit-tests, examples, state-tracking code and configuration abstraction.
http://fjblvrw2jrxnhtg67qpbzi45r7ofojaoo3orzykesly2j3c2m3htapid.onion/
MIT License
249 stars 72 forks source link

Many tests in test.test_endpoints.EndpointTests fail when calling `_tor_launcher` with incompatible arguments #356

Closed exarkun closed 3 years ago

exarkun commented 3 years ago 
[ERROR]
Traceback (most recent call last):
  File "/build/txtorcon-21.0.0/test/test_endpoints.py", line 123, in test_global_tor_error
    yield get_global_tor(
  File "/build/txtorcon-21.0.0/txtorcon/endpoints.py", line 131, in get_global_tor
    tor = yield get_global_tor_instance(
  File "/nix/store/73djff0qryqiv6djqysjwylkqwlvmsp3-python3.9-Twisted-21.7.0/lib/python3.9/site-packages/twisted/internet/defer.py", line 1661, in _inlineCallbacks
    result = current_context.run(gen.send, result)
  File "/build/txtorcon-21.0.0/txtorcon/endpoints.py", line 91, in get_global_tor_instance
    _global_tor = yield _tor_launcher(reactor, progress_updates=progress_updates)
builtins.TypeError: <lambda>() missing 1 required positional argument: 'y'

test.test_endpoints.EndpointTests.test_global_tor_error
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/build/txtorcon-21.0.0/txtorcon/endpoints.py", line 131, in get_global_tor
    tor = yield get_global_tor_instance(
  File "/nix/store/73djff0qryqiv6djqysjwylkqwlvmsp3-python3.9-Twisted-21.7.0/lib/python3.9/site-packages/twisted/internet/defer.py", line 1661, in _inlineCallbacks
    result = current_context.run(gen.send, result)
  File "/build/txtorcon-21.0.0/txtorcon/endpoints.py", line 91, in get_global_tor_instance
    _global_tor = yield _tor_launcher(reactor, progress_updates=progress_updates)
builtins.TypeError: <lambda>() missing 1 required positional argument: 'config'

test.test_endpoints.EndpointTests.test_parse_relative_path
test.test_endpoints.EndpointTests.test_parse_user_path
test.test_endpoints.EndpointTests.test_parse_via_plugin
test.test_endpoints.EndpointTests.test_parse_via_plugin_key_from_v3_private_file
test.test_endpoints.EndpointTests.test_progress_updates_private_tor
test.test_onion.OnionServiceTest.test_ephemeral_auth_stealth

This seems reproducable using:

python -m twisted.trial --random=162862258764 test

Notably, in my development-friendly environment, with the default trial test order, the tests do not fail.