Add the ability to override HTTPS TLS context

meejah / txtorcon

Twisted-based asynchronous Tor control protocol implementation. Includes unit-tests, examples, state-tracking code and configuration abstraction.

http://fjblvrw2jrxnhtg67qpbzi45r7ofojaoo3orzykesly2j3c2m3htapid.onion/

MIT License

250 stars 72 forks source link

Add the ability to override HTTPS TLS context #379

Closed itamarst closed 1 year ago

itamarst commented 1 year ago

Fixes #377

Todo:

[x] Manual testing that it didn't break anything
[x] Manual test to ensure custom TLS contexts actually work
[x] Unit testing for custom TLS context factory

coveralls commented 1 year ago

Coverage: 99.571% (-0.07%) from 99.644% when pulling d4363d202e91ad5086bcb72417999d3583ba8600 on itamarst:377.custom-web-context into c950149bf273f5bd27f254e9a1931c5fcfad3373 on meejah:main.

meejah commented 1 year ago

Ooof, forgot how much "mock" was in the test-suite :(

Looks great! The only thing I (maybe) noticed is that all the tests now pass pool= I think? But, not a huge deal.

meejah commented 1 year ago

(Hmmm, I think some of the "coverage loss" is because py2 is dropped, but I didn't remove all the py2-only lines?)

itamarst commented 1 year ago

I believe the tests passed pool in previously too.